How To Contribute¶
Every open source project lives from the generous help by contributors that sacrifice their time and
argon2_cffi is no different.
Here are a few guidelines to get you started:
If you want to install a development version of
argon2_cffiinto your current
virtualenv, you have to remember to:
git submodule init(to initialize git submodule mechanics)
git submodule update(to update the vendored Argon2 C library to the version
argon2_cffiis currently packaging)
python setup.py build(to build the CFFI module)
pip install -e .(to [re-]install it along with the Python code)
- To run tests, you also need to run
pip install -r dev-requirements.txt.
You have to perform steps 2, 3, and 4 whenever something changes in the Argon2 C code (e.g. if the vendored code has been updated).
Try to limit each pull request to one change only.
To run the test suite, all you need is a recent tox. It will ensure the test suite runs with all dependencies against all Python versions just as it will on Travis CI. If you lack some Python version, you can can always limit the environments like
tox -e py27,py35(in that case you may want to look into pyenv that makes it very easy to install many different Python versions in parallel).
Make sure your changes pass our CI. You won’t get any feedback until it’s green unless you ask for it.
If you address review feedback, make sure to bump the pull request. Maintainers don’t receive notifications if you push new commits.
If your change is noteworthy, add an entry to the changelog. Use present tense, semantic newlines, and add link to your pull request.
No contribution is too small; please submit as many fixes for typos and grammar bloopers as you can!
Don’t break backward compatibility.
Always add tests and docs for your code. This is a hard rule; patches with missing tests or documentation won’t be merged.
Write good test docstrings.
Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms. Please report any harm to Hynek Schlawack in any way you find appropriate.
Thank you for considering to contribute!
Contributor Covenant Code of Conduct¶
In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
Examples of behavior that contributes to creating a positive environment include:
- Using welcoming and inclusive language
- Being respectful of differing viewpoints and experiences
- Gracefully accepting constructive criticism
- Focusing on what is best for the community
- Showing empathy towards other community members
Examples of unacceptable behavior by participants include:
- The use of sexualized language or imagery and unwelcome sexual attention or advances
- Trolling, insulting/derogatory comments, and personal or political attacks
- Public or private harassment
- Publishing others’ private information, such as a physical or electronic address, without explicit permission
- Other conduct which could reasonably be considered inappropriate in a professional setting
Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at firstname.lastname@example.org. all complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project’s leadership.